Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip quotes-in-filename test on Windows #11

Merged
merged 1 commit into from
Mar 17, 2018
Merged

test: skip quotes-in-filename test on Windows #11

merged 1 commit into from
Mar 17, 2018

Conversation

nfischer
Copy link
Owner

Windows doesn't support having quotes inside a filename, so we need to
skip this test.

Issue #7

@nfischer
test: skip quotes-in-filename test on Windows
f17e49d 
Windows doesn't support having quotes inside a filename, so we need to
skip this test.

Issue #7
@nfischer nfischer added the test label Mar 17, 2018
@nfischer nfischer merged commit 51a4b93 into master Mar 17, 2018
@nfischer nfischer mentioned this pull request Mar 17, 2018
Merged
nfischer added a commit that referenced this pull request Mar 17, 2018
@nfischer
test: increase timeouts for flaky tests (#15)
b809b82 
This increases timeouts for the 2 flaky tests.

This also fixes a timeout issue for the "escapes quotes" test on Windows, since
we only invoked the done() callback from the unix code branch (a bug in #11).

Fixes #14
@nfischer nfischer deleted the even-more-test-fixes branch July 4, 2018 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nfischer